88 Merge Sorted Array (short circuiting)

Question:

Given two sorted integer arrays nums1 and nums2, merge nums2 into nums1 as one sorted array.

Note: You may assume that nums1 has enough space (size that is greater or equal to m + n) to hold additional elements from nums2. The number of elements initialized in nums1 and nums2 are m and n respectively.

Lesson Learned

if (i >= 0 && nums1[i] > nums2[j]) { // short circuiting
    nums1[pos--] = nums1[i--];

Code

However, still too long

public class Solution {
    public void merge(int[] nums1, int m, int[] nums2, int n) {
        int i = m - 1, j = n - 1;
        int pos = m + n - 1;
        while (i >= 0 && j >= 0) {
            if (nums2[j] > nums1[i]) {
                nums1[pos--] = nums2[j];
                j--;
            } else {
                nums1[pos--] = nums1[i];
                i--;
            }
        }
        if (j >= 0) {
            for (int k = 0; k <= j; k++) {
                nums1[k] = nums2[k];
            }
        }
    }
}

updated:

public class Solution {
    public void merge(int[] nums1, int m, int[] nums2, int n) {
        int i = m - 1, j = n - 1;
        int pos = m + n - 1;

        while (j >= 0) {
            if (i >= 0 && nums1[i] > nums2[j]) { // short circuitint
                nums1[pos--] = nums1[i--];
            } else {
                nums1[pos--] = nums2[j--];
            }
        }
    }
}

updated:

public class Solution {
    public void merge(int[] nums1, int m, int[] nums2, int n) {
        while (m > 0 && n > 0) {
            if (nums1[m - 1] < nums2[n - 1]) {
                nums1[m + n - 1] = nums2[n - 1];
                n--;
            } else {
                nums1[m + n - 1] = nums1[m - 1];
                m--;
            }
        }
        if (m == 0) {
            while (n > 0) {
                nums1[n - 1] = nums2[n - 1];
                n--;
            }
        }
    }
}